Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.12.0
-
Component/s: None
-
Labels:None
Description
Caused by: java.lang.AssertionError at org.apache.calcite.sql2rel.RelDecorrelator.decorrelateRel(RelDecorrelator.java:456)
The code is:
final Frame frame = getInvoke(oldInput, rel); if (frame == null) { // If input has not been rewritten, do not rewrite this rel. return null; } assert !frame.corVarOutputPos.isEmpty();
Seems like it's no need to assert the corVarOutputPos because in some cases, the correlate has been fully rewritten.
Issue Links
- links to
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Julian Hyde I used this query to reproduce:
select sum(l_extendedprice)
from lineitem, part
where
p_partkey = l_partkey
and l_quantity > (
select avg(l_quantity)
from lineitem
where l_partkey = p_partkey
)
There are two Aggregates in the operator tree, one with avg(l_quantity) will be affected by the correlation, but the outer aggregation sum(l_extendedprice) is not.
I have a code test case: see https://github.com/julianhyde/calcite/tree/1543-decorrelate-aggregate-scalar.
Hi Julian Hyde, i checked your test case, and you missed one thing:
"you need to call with(true) to enable the assertion", i also left comments in your commit.
Thanks for reproducing this.
Looks good; I have merged to my master branch and will push to Apache master after 1.11 is released.
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/408285f0. Thanks for the PR, Kurt Young!
Resolved in release 1.12.0 (2017-03-24).
Can you provide a test case for this?