Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1461

Hard-coded class name in JaninoRelMetadataProvider breaks shading

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.11.0
    • Component/s: None
    • Labels:
      None

      Description

      In JaninoRelMetadataProvider.load3, the generated class string contains some hard coded Calcite's classes, such as org.apache.calcite.rel.metadata.MetadataDef. After shading Calcite, the MetadataDef can not be found in the shaded classes. And a compile error will be thrown.

      So it's better to use MetadataDef.class.getName() to replace the hard code string.

      I'm appreciate to make a PR if you want.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Yes, please make a PR. I expect other people want to shade Calcite too (a sign of our increasing popularity, I guess).

          Show
          julianhyde Julian Hyde added a comment - Yes, please make a PR. I expect other people want to shade Calcite too (a sign of our increasing popularity, I guess).
          Hide
          jark Jark Wu added a comment -
          Show
          jark Jark Wu added a comment - Here is the PR link: https://github.com/apache/calcite/pull/318
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/3e886e9e . Thanks for the PR, Jark Wu !
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.11.0 (2017-01-11).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.11.0 (2017-01-11).

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              jark Jark Wu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development