Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1461

Hard-coded class name in JaninoRelMetadataProvider breaks shading

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.11.0
    • None
    • None

    Description

      In JaninoRelMetadataProvider.load3, the generated class string contains some hard coded Calcite's classes, such as org.apache.calcite.rel.metadata.MetadataDef. After shading Calcite, the MetadataDef can not be found in the shaded classes. And a compile error will be thrown.

      So it's better to use MetadataDef.class.getName() to replace the hard code string.

      I'm appreciate to make a PR if you want.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            jark Jark Wu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment