[CALCITE-1458] ColumnValue not backwards compatibile after CALCITE-1040

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: avatica-1.8.0, avatica-1.7.1, avatica-1.7.0, 1.6.0
• Fix Version/s: avatica-1.9.0
• Component/s: avatica
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 21/Oct/16 15:48
• Updated: 31/Oct/16 04:16
• Resolved: 21/Oct/16 18:11

Description

onpduo was nice enough to help me debug an issue using the C# driver against Avatica 1.8.1. We could see that a record was being placed into the database, but the C# driver wasn't returning the value.

After inspecting the server, I could see that the row was being returned by the server. Still the client claimed to not know about the value in the row.

Turns out, this was a botched backwards-compatibility issue introduced by CALCITE-1040. When the array_value and scalar_value fields were introduced, the original value field stopped having the values set in it. This caused the C# driver, which was still using that (now deprecated) field to stop seeing any records.

A simple fix to start adding the values for the row into that deprecated field seems to have fixed the issue.

Issue Links

• is broken by: CALCITE-1040 ColumnValue and TypedValue are unnecessarily both repeated
• links to: Github Pull Request #314