Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1416

Make classes implement AutoCloseable where possible

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.11.0
    • None

    Description

      If a class has a close method, make it implement AutoCloseable, so it can be used in try-with-resources. Some possible classes (they have a close method):

      • org.apache.calcite.tools.Planner
      • org.apache.calcite.interpreter.Interpreter
      • org.apache.calcite.interpreter.Source
      • Hook.Closeable (we can ditch JDK 1.6 support)
      • SqlTesterImpl

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            julianhyde Julian Hyde
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment