Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1416

Make classes implement AutoCloseable where possible

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.11.0
    • Component/s: None
    • Labels:

      Description

      If a class has a close method, make it implement AutoCloseable, so it can be used in try-with-resources. Some possible classes (they have a close method):

      • org.apache.calcite.tools.Planner
      • org.apache.calcite.interpreter.Interpreter
      • org.apache.calcite.interpreter.Source
      • Hook.Closeable (we can ditch JDK 1.6 support)
      • SqlTesterImpl

        Issue Links

          Activity

          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/6378fa68 ; thanks for the PR, Chinmay Kolhatkar !
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.11.0 (2017-01-11).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.11.0 (2017-01-11).

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development