Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1400

AggregatePullUpConstantsRule might adjust aggregation function parameters indices wrongly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.0
    • Fix Version/s: 1.10.0
    • Component/s: core
    • Labels:
      None

      Description

      I explored a bit and I think this is a piece missing in CALCITE-1038. Introducing a Project operator below as part of the rewriting was removed, and thus, there is no need to adjust the indices of the aggregation function parameters. However, the code is still there.

        Activity

        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        PR with fix is in : https://github.com/apache/calcite/pull/289

        Tests pass w/o the fix. I still need to add a new test case to cover this, but it should not be too difficult.

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - PR with fix is in : https://github.com/apache/calcite/pull/289 Tests pass w/o the fix. I still need to add a new test case to cover this, but it should not be too difficult.
        Hide
        julianhyde Julian Hyde added a comment -

        +1 when you have a test that fails without the fix, passes with it.

        Show
        julianhyde Julian Hyde added a comment - +1 when you have a test that fails without the fix, passes with it.
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -
        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Thanks Julian Hyde . Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/22ddc82 (including the test).
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Resolved in release 1.10.0 (2016-10-12).

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.10.0 (2016-10-12).

          People

          • Assignee:
            jcamachorodriguez Jesus Camacho Rodriguez
            Reporter:
            jcamachorodriguez Jesus Camacho Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development