Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1379

When expanding STAR, expand sub-fields in RecordType columns of StructKind.PEEK_FIELDS and StructKind.PEEK_FIELDS_DEFAULT

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.0
    • Fix Version/s: 1.10.0
    • Component/s: None
    • Labels:

      Description

      This is part of CALCITE-1208 and is a Phoenix-specific requirement.
      For example, if table T's type is defined as

      VARCHAR K0,
      VARCHAR C1,
      RecordType(INTEGER C0, INTEGER C1) F0,
      RecordType(INTEGER C0, INTEGER C2) F1
      

      , where both F0 and F1 is of StructKind.PEEK_FIELDS or StructKind.PEEK_FIELDS_DEFAULT,
      "select * from T" should expand the sub-fields of F0 and F1 and has a return type of

      VARCHAR K0,
      VARCHAR C1,
      INTEGER F0.C0,
      INTEGER F0.C1,
      INTEGER F1.C0,
      INTEGER F1.C2
      

        Issue Links

          Activity

          Hide
          maryannxue Maryann Xue added a comment -

          Hi, Julian Hyde, could you also review this patch? Thank you in advance!

          Show
          maryannxue Maryann Xue added a comment - Hi, Julian Hyde , could you also review this patch? Thank you in advance!
          Hide
          julianhyde Julian Hyde added a comment -

          Maybe plusStar could be non-static? Anyway, +1.

          Show
          julianhyde Julian Hyde added a comment - Maybe plusStar could be non-static? Anyway, +1.
          Hide
          maryannxue Maryann Xue added a comment -

          Thanks a lot, Julian Hyde, for the review, and for this good point!

          Show
          maryannxue Maryann Xue added a comment - Thanks a lot, Julian Hyde , for the review, and for this good point!
          Show
          maryannxue Maryann Xue added a comment - Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=a877d70 .
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.10.0 (2016-10-12).

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.10.0 (2016-10-12).

            People

            • Assignee:
              maryannxue Maryann Xue
              Reporter:
              maryannxue Maryann Xue
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development