Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1273

Update references to EnumerableTableAccessRel to EnumerableTableScan

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      TranslatableTable mentions EnumerableTableAccessRel which no longer exists. I'm not sure how the situation has changed now but it would be nice if the documentation could be updated to reflect this.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.8.0 (2016-06-13).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.8.0 (2016-06-13).
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/063f5788 .
        Hide
        michaelmior Michael Mior added a comment -

        Okay, great. I'll leave this one to you then

        Show
        michaelmior Michael Mior added a comment - Okay, great. I'll leave this one to you then
        Hide
        julianhyde Julian Hyde added a comment -

        I think it's fair to say that the tests aren't run as often as they should be.

        By the way, I've fixed most of the outdated references in my "scratch" branch, which will become the release notes for 1.8.0: https://github.com/julianhyde/calcite/commit/181820f9be1c6b26e006aa07af7e797ca91f23ad.

        Show
        julianhyde Julian Hyde added a comment - I think it's fair to say that the tests aren't run as often as they should be. By the way, I've fixed most of the outdated references in my "scratch" branch, which will become the release notes for 1.8.0: https://github.com/julianhyde/calcite/commit/181820f9be1c6b26e006aa07af7e797ca91f23ad .
        Hide
        michaelmior Michael Mior added a comment -

        What's the status of the TPC-DS adapter? I see that the tests for it still mention EnumerableTableAccessRel so I assume no one runs these tests anymore (or they would have failed).

        Show
        michaelmior Michael Mior added a comment - What's the status of the TPC-DS adapter? I see that the tests for it still mention EnumerableTableAccessRel so I assume no one runs these tests anymore (or they would have failed).
        Hide
        julianhyde Julian Hyde added a comment - - edited

        We renamed EnumerableTableAccessRel to EnumerableTableScan in CALCITE-306. I guess that javadoc comment was missed because it wasn't inside a {@link ... }. There are a few other occurrences of EnumerableTableAccessRel in the code that should be fixed, including one in the tutorial!

        Show
        julianhyde Julian Hyde added a comment - - edited We renamed EnumerableTableAccessRel to EnumerableTableScan in CALCITE-306 . I guess that javadoc comment was missed because it wasn't inside a {@link ... } . There are a few other occurrences of EnumerableTableAccessRel in the code that should be fixed, including one in the tutorial!

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            michaelmior Michael Mior
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development