Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1246

Cleanup duplicate variables in JoinPushThroughJoinRule

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: core
    • Labels:
      None

      Description

      When splitting condition of bottom join in JoinPushThroughJoinRule.onMatchLeft function, threre's a typo in comment: `B` -> `A`.

      In onMatchRight/Left function, bottomMapping and bottomBottomMapping are same values. We could cleanup one of them.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.8.0 (2016-06-13).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.8.0 (2016-06-13).
        Hide
        julianhyde Julian Hyde added a comment -
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/b6f0e102 . Thanks for the PR, yixinglu !

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            yee Yi Xinglu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development