Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1246

Cleanup duplicate variables in JoinPushThroughJoinRule

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: core
    • Labels:
      None

      Description

      When splitting condition of bottom join in JoinPushThroughJoinRule.onMatchLeft function, threre's a typo in comment: `B` -> `A`.

      In onMatchRight/Left function, bottomMapping and bottomBottomMapping are same values. We could cleanup one of them.

        Attachments

          Activity

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              yee Yi Xinglu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: