Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1205

Inconsistency in protobuf TypedValue field names

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • avatica-1.8.0
    • avatica
    • None

    Description

      Francis Chuang pointed out over in CALCITE-1192 that the "byte array" field in the protobuf TypedValue message has the name "bytes_values" instead of "bytes_value". Plural here does not make sense (as it is a single collection of bytes, not multiple collections of bytes).

      Changing the field name will not have an affect on binary compatibility, so I'm going to go ahead and make that change. The java API will change ever-so-slightly, but we haven't defined what our Java API is truly comprised of and to what degree we are providing stability, so we'll just ignore that for now.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            elserj Josh Elser
            elserj Josh Elser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment