Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1200

Handle null equality join condition as IS NOT DISTINCT FROM in RelOptUtil.splitJoinCondition

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: core
    • Labels:
      None

      Description

      Currently RelOptUtil.splitJoinCondition can't recognize a join condition as equi-join condition if it is given as (t1.key = t2.key OR (t1.key IS NULL AND t2.key IS NULL)) which is basically an expanded version of IS NOT DISTINCT FROM function.

      This JIRA is to track changes to RelOptUtil.splitJoinCondition to handle null equality join condition by converting them to IS NOT DISTINCT FROM function.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.8.0 (2016-06-13).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.8.0 (2016-06-13).
          Hide
          julianhyde Julian Hyde added a comment -

          Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/3599cebb. Thanks for the PR!

          I fixed up a bit, changing getOperator() calls to getKind() for the reasons stated in CALCITE-1043.

          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/3599cebb . Thanks for the PR! I fixed up a bit, changing getOperator() calls to getKind() for the reasons stated in CALCITE-1043 .
          Hide
          julianhyde Julian Hyde added a comment -

          Venki Korukanti, I saw your request to review. I am swamped for the next day or two but will review as soon as I can.

          Show
          julianhyde Julian Hyde added a comment - Venki Korukanti , I saw your request to review. I am swamped for the next day or two but will review as soon as I can.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              vkorukanti Venki Korukanti
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development