Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1151

Fix SqlSetOption to correctly handle SqlOperator.createCall

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None
    1. CALCITE-1151-0.patch
      1 kB
      Sudheesh Katkam

      Activity

      Hide
      sudheeshkatkam Sudheesh Katkam added a comment -

      The attached patch is a continuation of CALCITE-322.

      Does this patch require a unit test? I looked around for similar tests, and I could not find any. If there is way, please show me, and I will update the patch.

      Jacques Nadeau can you please review?

      Show
      sudheeshkatkam Sudheesh Katkam added a comment - The attached patch is a continuation of CALCITE-322 . Does this patch require a unit test? I looked around for similar tests, and I could not find any. If there is way, please show me, and I will update the patch. Jacques Nadeau can you please review?
      Hide
      julianhyde Julian Hyde added a comment -

      What is the bug you are trying to fix? Maybe you could extend SqlParserTest and once you have a parse tree, invoke a SqlShuttle on it.

      Show
      julianhyde Julian Hyde added a comment - What is the bug you are trying to fix? Maybe you could extend SqlParserTest and once you have a parse tree, invoke a SqlShuttle on it.
      Show
      minjikim MinJi Kim added a comment - https://github.com/apache/calcite/pull/244
      Hide
      julianhyde Julian Hyde added a comment -
      Show
      julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/fa767791 . Thanks for the PRs, Sudheesh Katkam and MinJi Kim !
      Hide
      sudheeshkatkam Sudheesh Katkam added a comment -

      Thank you MinJi Kim!

      Show
      sudheeshkatkam Sudheesh Katkam added a comment - Thank you MinJi Kim !
      Hide
      julianhyde Julian Hyde added a comment -

      Resolved in release 1.8.0 (2016-06-13).

      Show
      julianhyde Julian Hyde added a comment - Resolved in release 1.8.0 (2016-06-13).

        People

        • Assignee:
          julianhyde Julian Hyde
          Reporter:
          jnadeau Jacques Nadeau
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development