Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1130

Add unary operator support for IS_NULL and IS_NOT_NULL to RexImplicationChecker

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently we support only SQL Comparison operators (SqlKind.COMPARE) for checking if one predicate implies another using RexImplicationChecker.
      We would like to extend it for couple of Unary operators based on user request ( CALCITE-1104): IS_NULL and IS_NOT_NULL

        Activity

        Hide
        amargoor Amogh Margoor added a comment -
        Show
        amargoor Amogh Margoor added a comment - PR Raised: https://github.com/apache/calcite/pull/207
        Hide
        julianhyde Julian Hyde added a comment -

        +1 looks good - thanks for the rapid turnaround!

        Michael Mior, Does this PR solve the issue in CALCITE-1104? If so I'll commit.

        Show
        julianhyde Julian Hyde added a comment - +1 looks good - thanks for the rapid turnaround! Michael Mior , Does this PR solve the issue in CALCITE-1104 ? If so I'll commit.
        Hide
        michaelmior Michael Mior added a comment -

        Yup! This seems to fix things. I still have a couple other issues to sort through with CALCITE-1104, but this seems to work as expected. Thanks Amogh Margoor!

        Show
        michaelmior Michael Mior added a comment - Yup! This seems to fix things. I still have a couple other issues to sort through with CALCITE-1104 , but this seems to work as expected. Thanks Amogh Margoor !
        Hide
        julianhyde Julian Hyde added a comment -
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/82c3b293 . Thanks for the PR, Amogh Margoor !
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.7.0 (2016-03-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.7.0 (2016-03-22).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            amargoor Amogh Margoor
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development