Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1125

Add MINUS keyword

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.11.0
        • Component/s: None
        • Labels:

          Description

          Oracle database supports the usage of "MINUS" keyword but calcite has not supported it yet.

            Issue Links

            is depended upon by

            New Feature - A new feature of the product, which has yet to be developed. CALCITE-1446 Support INTERSECT, EXCEPT, MINUS, each with DISTINCT, ALL options

            • Major - Major loss of function.
            • Open

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Add the keyword to the parser, add a method SqlConformance.allowMinus that returns true for Oracle, and check that parser throws if it's not Oracle. The implementation will be similar to the work done in CALCITE-1374.

              Show
              julianhyde Julian Hyde added a comment - Add the keyword to the parser, add a method SqlConformance.allowMinus that returns true for Oracle, and check that parser throws if it's not Oracle. The implementation will be similar to the work done in CALCITE-1374 .
              Hide
              Permalink
              csingh Chandni Singh added a comment -

              Created pull request:
              https://github.com/apache/calcite/pull/321

              Show
              csingh Chandni Singh added a comment - Created pull request: https://github.com/apache/calcite/pull/321
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              I quickly looked over your PR, and looks great. You've covered all the bases. I'll merge, and will commit after the avatica vote finishes.

              (The travis failures are probably not your fault - travis is flaky - but if they are, I'll fix.)

              Show
              julianhyde Julian Hyde added a comment - I quickly looked over your PR, and looks great. You've covered all the bases. I'll merge, and will commit after the avatica vote finishes. (The travis failures are probably not your fault - travis is flaky - but if they are, I'll fix.)
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/aa8fe082; thanks for the PR, Chandni Singh!

              Show
              julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/aa8fe082 ; thanks for the PR, Chandni Singh !
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Resolved in release 1.11.0 (2017-01-11).

              Show
              julianhyde Julian Hyde added a comment - Resolved in release 1.11.0 (2017-01-11).

                People

                • Assignee:
                  julianhyde Julian Hyde
                  Reporter:
                  ssamra Sameh Samra
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development