Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1030

Json ModelHandler calling SchemaPlus.setCacheEnabled() causes UnsupportedOperationException when using SimpleCalciteSchema

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Think we can either ignore setCache() in SimpleCalciteSchema or do not call setCacheEnabled() when JsonSchema.cache is null.

        Activity

        Hide
        maryannxue Maryann Xue added a comment -

        Julian Hyde, what do you think would the solution that makes more sense?

        Show
        maryannxue Maryann Xue added a comment - Julian Hyde , what do you think would the solution that makes more sense?
        Hide
        julianhyde Julian Hyde added a comment -

        I think we should not call setCacheEnabled() when JsonSchema.cache is null. Anyone writing a model file will know whether the particular schema supports caching.

        Show
        julianhyde Julian Hyde added a comment - I think we should not call setCacheEnabled() when JsonSchema.cache is null. Anyone writing a model file will know whether the particular schema supports caching.
        Hide
        maryannxue Maryann Xue added a comment -

        Thank you Julian Hyde for the advice! I'll go ahead and check-in the fix.

        Show
        maryannxue Maryann Xue added a comment - Thank you Julian Hyde for the advice! I'll go ahead and check-in the fix.
        Show
        maryannxue Maryann Xue added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/39f505f .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            maryannxue Maryann Xue
            Reporter:
            maryannxue Maryann Xue
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development