Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1028

Move populate materializations after sql-to-rel conversion

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:

      Description

      This is to allow Phoenix to figure out which materializations are concerned with the query and thus have a chance to define them right before materializations are populated.

        Activity

        Hide
        maryannxue Maryann Xue added a comment -

        Could you please help review this patch, Julian Hyde? It also includes a bug fix for populateMaterializations():
        populateMaterialization() should use the same "viewSchemaPath" as used in defineMaterialization() for parsing and validating the sql. Otherwise if "viewSchemaPath" happens to be different from the materialization schema path itself, validation would fail in populateMaterialization().

        Show
        maryannxue Maryann Xue added a comment - Could you please help review this patch, Julian Hyde ? It also includes a bug fix for populateMaterializations(): populateMaterialization() should use the same "viewSchemaPath" as used in defineMaterialization() for parsing and validating the sql. Otherwise if "viewSchemaPath" happens to be different from the materialization schema path itself, validation would fail in populateMaterialization().
        Hide
        julianhyde Julian Hyde added a comment -
        • getMaterializations and getLattices could use some javadoc
        • I generally don't use Override if I am implementing, not overriding, a method; and if I do use Override, I usually put it on the same line as the rest of the declaration
        • is there a test case for the bug that was fixed by passing viewSchemaPath?
        Show
        julianhyde Julian Hyde added a comment - getMaterializations and getLattices could use some javadoc I generally don't use Override if I am implementing, not overriding, a method; and if I do use Override, I usually put it on the same line as the rest of the declaration is there a test case for the bug that was fixed by passing viewSchemaPath?
        Hide
        julianhyde Julian Hyde added a comment -

        The extended test suite passed; go ahead and check in whenever you like.

        Show
        julianhyde Julian Hyde added a comment - The extended test suite passed; go ahead and check in whenever you like.
        Hide
        maryannxue Maryann Xue added a comment - - edited

        Thank you, Julian Hyde, for the comment! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/05fbd12. Adjusted @Override and Added a test case.

        Show
        maryannxue Maryann Xue added a comment - - edited Thank you, Julian Hyde , for the comment! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/05fbd12 . Adjusted @Override and Added a test case.
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            maryannxue Maryann Xue
            Reporter:
            maryannxue Maryann Xue
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development