Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1024

In a planner test, if a rule should have no effect, state that explicitly

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.6.0
    • None
    • None

    Description

      Add method RelOptRulesTestBase.checkPlanUnchanged method, and also add a boolean unchanged parameter to the underlying checkPlanning method. If a planner test is supposed to have no effect, that is, if the before and after plans are the same, then you must specify that flag.

      This makes it easier to notice if a rule that is supposed to work has stopped working. It also removes redundant plans from the reference file.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            julianhyde Julian Hyde
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment