Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1024

In a planner test, if a rule should have no effect, state that explicitly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Add method RelOptRulesTestBase.checkPlanUnchanged method, and also add a boolean unchanged parameter to the underlying checkPlanning method. If a planner test is supposed to have no effect, that is, if the before and after plans are the same, then you must specify that flag.

      This makes it easier to notice if a rule that is supposed to work has stopped working. It also removes redundant plans from the reference file.

        Activity

        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/d55ff83f .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.6.0 (2016-01-22).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development