[CALCITE-1024] In a planner test, if a rule should have no effect, state that explicitly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 12/Dec/15 00:22
• Updated: 21/Jan/16 22:20
• Resolved: 14/Dec/15 00:56

Description

Add method RelOptRulesTestBase.checkPlanUnchanged method, and also add a boolean unchanged parameter to the underlying checkPlanning method. If a planner test is supposed to have no effect, that is, if the before and after plans are the same, then you must specify that flag.

This makes it easier to notice if a rule that is supposed to work has stopped working. It also removes redundant plans from the reference file.