Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1019

RelMdUtil.checkInputForCollationAndLimit() was wrong with alreadySorted check

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.6.0
        • Component/s: None
        • Labels:
          None

          Description

          The below line works incorrectly with EMPTY collation:

              final boolean alreadySorted = RelCollations.equal(
        ImmutableList.of(collation), inputCollation);

            Issue Links

            blocks

            Bug - A problem which impairs or prevents the functions of the product. CALCITE-1018 SortJoinTransposeRule not firing due to getMaxRowCount(RelSubset) returning null

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              jcamachorodriguez Jesus Camacho Rodriguez added a comment -

              This one looks good to me Maryann Xue, I should have double-checked for other corner cases when I implemented the original method. Thanks

              Show
              jcamachorodriguez Jesus Camacho Rodriguez added a comment - This one looks good to me Maryann Xue , I should have double-checked for other corner cases when I implemented the original method. Thanks
              Hide
              Permalink
              maryannxue Maryann Xue added a comment -

              Thank you, Jesus Camacho Rodriguez, for the review!
              Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/352aaea.

              Show
              maryannxue Maryann Xue added a comment - Thank you, Jesus Camacho Rodriguez , for the review! Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/352aaea .
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Resolved in release 1.6.0 (2016-01-22).

              Show
              julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).

                People

                • Assignee:
                  maryannxue Maryann Xue
                  Reporter:
                  maryannxue Maryann Xue
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development