Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1010

Support FETCH/LIMIT and OFFSET in RelToSqlConverter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Extend RelToSqlConverter to support FETCH/LIMIT and OFFSET.

      FETCH is the standard but LIMIT is more common. Therefore we will need to extend the Dialect to know which syntax a particular database prefers. If it accepts both, let's generate standard SQL syntax.

      Work has already started in https://github.com/amoghmargoor/incubator-calcite/tree/CALCITE-1003.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.6.0 (2016-01-22).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.6.0 (2016-01-22).
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/82fd259c . Thanks for the PR, Amogh Margoor !
          Show
          amargoor Amogh Margoor added a comment - Hi Julian Hyde I have raised PR for this: https://github.com/apache/calcite/pull/179 Tests looks clean: https://travis-ci.org/qubole/incubator-calcite/builds/96717101

            People

            • Assignee:
              amargoor Amogh Margoor
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development