[CACTUS-235] TestShareAll suite adds TestHttpSession tests incorrectly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.8
• Component/s: Servlet Sample
• Environment: Windows XP, WSAD 5.1.2
• Assignee: Petar Tahchiev
• Reporter: Jeff Glass
• Created: 07/Jan/06 05:23
• Updated: 11/Apr/08 12:37
• Resolved: 02/Mar/08 22:34

Description

The method org.apache.cactus.sample.servlet.unit.TestShareAll.suite() adds the TestHttpSession tests to the suite incorrectly. It doesn't call TestHttpSession.suite(), so the tests are not properly set up, and as a result TestHttpSession.beginDependentTestUsingSession2(WebRequest) throws a null-pointer exception (because this.dependentTest is null).

I found this problem when running the Cactus sample tests through a web browser (http://localhost:9080/testweb/ServletTestRunner?suite=org.apache.cactus.sample.servlet.unit.TestShareAll).

The patch follows.

/jeff

— TestShareAll.java.orig 2006-01-06 14:54:00.663897700 -0500
+++ TestShareAll.java 2006-01-06 14:54:32.600776000 -0500
@@ -55,7 +55,7 @@
suite.addTestSuite(TestHttpUnitIntegration.class);
suite.addTestSuite(TestServletRedirectorOverride.class);
suite.addTestSuite(TestHttpParameters.class);

• suite.addTestSuite(TestHttpSession.class);
  + suite.addTest(TestHttpSession.suite());
  suite.addTestSuite(TestHttpResponse.class);
  suite.addTestSuite(TestCookie.class);
  suite.addTestSuite(TestRequestDispatcher.class);