Cactus
  1. Cactus
  2. CACTUS-189

cactifywar cannot merge servlets run-as element

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.1
    • Component/s: Ant Integration
    • Labels:
      None

      Description

      To have the tests run as a certain principal I merge in a web.xml file containing the following snippet:

      <servlet>
      <servlet-name>ServletRedirector</servlet-name>
      <servlet-class>org.apache.cactus.server.ServletTestRedirector</servlet-class>
      <run-as>
      <role-name>myTrustedUser</role-name>
      </run-as>
      </servlet>

      However the run-as element does not end up in the merged web.xml file.

      1. cactus-patch.txt
        5 kB
        Magnus Grimsell

        Activity

        Hide
        Magnus Grimsell added a comment -

        I have made a patch to fix this problem by letting the WebXmlMerger acknowledge run-as elements.

        Show
        Magnus Grimsell added a comment - I have made a patch to fix this problem by letting the WebXmlMerger acknowledge run-as elements.
        Hide
        Vincent Massol added a comment -

        Applied. Thanks! If you have some time for writing some unit tests too that would be very cool (hint: there's an existing WebXmlTest file that could be updated with a test which proves it works).

        Show
        Vincent Massol added a comment - Applied. Thanks! If you have some time for writing some unit tests too that would be very cool (hint: there's an existing WebXmlTest file that could be updated with a test which proves it works).

          People

          • Assignee:
            Vincent Massol
            Reporter:
            Magnus Grimsell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development