Cactus
  1. Cactus
  2. CACTUS-161

maven.compile.[target|source] usage incorrect

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Component/s: Maven Integration
    • Labels:
      None

      Description

      in cactus:compile,

      use of target="...maven.compile.target..." is incorrect, as maven.compile.target can be empty, and is by default in Maven 1.0.2.

      Instead, should conditionally use <setproperty />, as is done for maven.compile.source later.

      Also, source is now duplicated by the source="..." parameter to javac. It should be removed, and rely on the later property setting.

      Let me know if this isn't clear, I'll do a patch.

      1. CACTUS-161.diff
        2 kB
        Brett Porter

        Activity

        Hide
        Felipe Leme added a comment -

        Applied, thanks...

        Show
        Felipe Leme added a comment - Applied, thanks...
        Hide
        Brett Porter added a comment -

        patch

        Show
        Brett Porter added a comment - patch
        Hide
        Felipe Leme added a comment -

        It's clear, but a patch would be very welcome anyways

        Show
        Felipe Leme added a comment - It's clear, but a patch would be very welcome anyways

          People

          • Assignee:
            Felipe Leme
            Reporter:
            Brett Porter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development