Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8
    • Component/s: Ant Integration
    • Labels:
      None

      Description

      Support for JBoss 4.0 deployment

        Issue Links

          Activity

          Petar Tahchiev made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Petar Tahchiev made changes -
          Assignee Petar Tahchiev [ paranoiabla ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          Petar Tahchiev added a comment -

          Already fixed in Cactus SVN HEAD. I am closing this issue.

          Show
          Petar Tahchiev added a comment - Already fixed in Cactus SVN HEAD. I am closing this issue.
          Felipe Leme made changes -
          Fix Version/s 1.7.1 [ 11065 ]
          Fix Version/s 1.8 [ 12310167 ]
          Felipe Leme made changes -
          Assignee Felipe Leme [ felipeal ]
          Felipe Leme made changes -
          Affects Version/s 1.6.1 [ 10715 ]
          Fix Version/s 1.8 [ 11065 ]
          Fix Version/s 1.7.1 [ 12310160 ]
          Affects Version/s 1.7 [ 10693 ]
          Hide
          Felipe Leme added a comment -

          I was planning to fix this bug as is, i.e., without refactoring the code, but then I realize that are too many things that must be changed, as JBoss 4.0 is a J2EE 1.4 server (and 3.x was 1.3).
          So, we better leave it to the Cargo integration on Cactus 1.8...

          Show
          Felipe Leme added a comment - I was planning to fix this bug as is, i.e., without refactoring the code, but then I realize that are too many things that must be changed, as JBoss 4.0 is a J2EE 1.4 server (and 3.x was 1.3). So, we better leave it to the Cargo integration on Cactus 1.8...
          Felipe Leme made changes -
          Fix Version/s 1.7.1 [ 12310160 ]
          Affects Version/s 1.7 [ 10693 ]
          Environment
          Felipe Leme made changes -
          Assignee Felipe Leme [ felipeal ]
          Hide
          Felipe Leme added a comment -

          I agree with Wonne that it should be incorporated before the Cargo integration, but as the patch poster said, it needs some refactoring: right now it's just a copy & paste of the JBoss 3 code.

          I started such refactoring a couple of nights ago, but haven't had the time to finish it out (and unfortunately won't be able to continue in the next days). Basically, I created a new AbstractJBossContainer class and tried to move most of the common code there, using the Template Pattern in some methods.

          – Felipe

          Show
          Felipe Leme added a comment - I agree with Wonne that it should be incorporated before the Cargo integration, but as the patch poster said, it needs some refactoring: right now it's just a copy & paste of the JBoss 3 code. I started such refactoring a couple of nights ago, but haven't had the time to finish it out (and unfortunately won't be able to continue in the next days). Basically, I created a new AbstractJBossContainer class and tried to move most of the common code there, using the Template Pattern in some methods. – Felipe
          Hide
          Wonne Keysers added a comment -

          Please include this patch in the following release.
          At least this patch enables people to already start using Cactus with JBoss 4 instead of waiting for this Cargo refactoring to be finished...

          Show
          Wonne Keysers added a comment - Please include this patch in the following release. At least this patch enables people to already start using Cactus with JBoss 4 instead of waiting for this Cargo refactoring to be finished...
          Felipe Leme made changes -
          Affects Version/s 1.7 [ 10693 ]
          Affects Version/s 1.6.1 [ 10715 ]
          Component/s Other [ 10897 ]
          Component/s Cargo Integration [ 11455 ]
          Hide
          Felipe Leme added a comment -

          Changed component and version.

          Show
          Felipe Leme added a comment - Changed component and version.
          Vincent Massol made changes -
          Link This issue depends upon CACTUS-151 [ CACTUS-151 ]
          Hide
          Vincent Massol added a comment -

          Thanks Marcus. We're currently refactoring the Ant integration to use Cargo (http://cargo.codehaus.org) and in the near future all the container logic will be in Cargo. Your patch will not be lost as we'll be able to use it to implement JBoss 4.x support for Cargo. If you wish to participate to cargo please join us on the Cargo mailing list.

          Thanks
          -Vincent

          Show
          Vincent Massol added a comment - Thanks Marcus. We're currently refactoring the Ant integration to use Cargo ( http://cargo.codehaus.org ) and in the near future all the container logic will be in Cargo. Your patch will not be lost as we'll be able to use it to implement JBoss 4.x support for Cargo. If you wish to participate to cargo please join us on the Cargo mailing list. Thanks -Vincent
          Markus Cozowicz made changes -
          Field Original Value New Value
          Attachment jakarta-cactus-src-1.6.1-jboss-4x.zip [ 18080 ]
          Hide
          Markus Cozowicz added a comment -

          That stuff should be refactored

          Show
          Markus Cozowicz added a comment - That stuff should be refactored
          Markus Cozowicz created issue -

            People

            • Assignee:
              Petar Tahchiev
              Reporter:
              Markus Cozowicz
            • Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development