Uploaded image for project: 'Cactus'
  1. Cactus
  2. CACTUS-146

[PATCH] cactus:test should skip tests if maven.test.skip is true

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.7
    • Component/s: Maven Integration
    • Labels:
      None

      Description

      Vincent,

      It would be nice if we could instruct cactus to skip running its tests, and the simplest (and most consistent) way would be checking for maven.test.skip at cactus:test.

      So, I'm providing a simple patch that does so.

      – Felipe

        Issue Links

          Activity

          Hide
          felipeal Felipe Leme added a comment -

          Here is the patch I promised...

          Show
          felipeal Felipe Leme added a comment - Here is the patch I promised...
          Hide
          felipeal Felipe Leme added a comment -

          Vincent,

          If you're ok with this simple proposal, I can write a test case and then commit the changes.

          – Felipe

          Show
          felipeal Felipe Leme added a comment - Vincent, If you're ok with this simple proposal, I can write a test case and then commit the changes. – Felipe
          Hide
          vmassol Vincent Massol added a comment -

          Fine with me. Thanks.

          Show
          vmassol Vincent Massol added a comment - Fine with me. Thanks.
          Hide
          felipeal Felipe Leme added a comment -

          Ok, done...

          Show
          felipeal Felipe Leme added a comment - Ok, done...
          Hide
          vmassol Vincent Massol added a comment -

          Please use the "Fix for" field so that we can see what's fixed for a given release by looking at the JIRA roadmap. Also, when an issue is resolved you can close it.

          Show
          vmassol Vincent Massol added a comment - Please use the "Fix for" field so that we can see what's fixed for a given release by looking at the JIRA roadmap. Also, when an issue is resolved you can close it.
          Hide
          vmassol Vincent Massol added a comment -

          Done.

          Show
          vmassol Vincent Massol added a comment - Done.
          Hide
          felipeal Felipe Leme added a comment -

          Vincent,

          I realized I missed the 'fix for' in some issues and I was planning to change it later, when I marked them as closed.

          Also, I prefered to mark them as 'fixed' so we could have some time to test the fixes (specially by Gump's builds) before closing them, but I will skip that phase next time (after all, it's always possible to reopen an issue

          – Felipe

          Show
          felipeal Felipe Leme added a comment - Vincent, I realized I missed the 'fix for' in some issues and I was planning to change it later, when I marked them as closed. Also, I prefered to mark them as 'fixed' so we could have some time to test the fixes (specially by Gump's builds) before closing them, but I will skip that phase next time (after all, it's always possible to reopen an issue – Felipe

            People

            • Assignee:
              felipeal Felipe Leme
              Reporter:
              felipeal Felipe Leme
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development