Cactus
  1. Cactus
  2. CACTUS-128

cactus.sysproperties used inconsistently

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7.1
    • Component/s: Maven Integration
    • Labels:
      None
    • Environment:
      Maven 1.0rc3, Cactus-CVS-HEAD, Gentoo Linux

      Description

      In the latest version of plugin.jelly in cvs, the cactus task uses cactus.sysproperties in the same way as in the maven-test-plugin uses maven.junit.sysproperties.

      However, it only sets such properties when executing the cactus:test-war goal, not the cactus:match nor the cactus:single goals. The attached patch fixes this problem

      For full consistency with the maven-test-plugin, the sysproperty basedir would be set to $

      {basedir}

      , but that is obviously at your discretion.

      1. sysproperties.patch
        2 kB
        Maxwell Grender-Jones

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        125d 11h 43m 1 Felipe Leme 24/Oct/04 06:14
        Closed Closed Reopened Reopened
        359d 21h 25m 1 Felipe Leme 19/Oct/05 03:40
        Reopened Reopened Closed Closed
        88d 7h 23m 1 Felipe Leme 15/Jan/06 10:03
        Felipe Leme made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 1.7.2 [ 12310700 ]
        Status Reopened [ 4 ] Closed [ 6 ]
        Fix Version/s 1.7.1 [ 11065 ]
        Hide
        Felipe Leme added a comment -

        Nevermind, it's done on test-ear as wel...

        Show
        Felipe Leme added a comment - Nevermind, it's done on test-ear as wel...
        Felipe Leme made changes -
        Fix Version/s 1.7.2 [ 12310700 ]
        Fix Version/s 1.7 [ 10693 ]
        Description In the latest version of plugin.jelly in cvs, the cactus task uses cactus.sysproperties in the same way as in the maven-test-plugin uses maven.junit.sysproperties.

        However, it only sets such properties when executing the cactus:test-war goal, not the cactus:match nor the cactus:single goals. The attached patch fixes this problem

        For full consistency with the maven-test-plugin, the sysproperty basedir would be set to ${basedir}, but that is obviously at your discretion.
        In the latest version of plugin.jelly in cvs, the cactus task uses cactus.sysproperties in the same way as in the maven-test-plugin uses maven.junit.sysproperties.

        However, it only sets such properties when executing the cactus:test-war goal, not the cactus:match nor the cactus:single goals. The attached patch fixes this problem

        For full consistency with the maven-test-plugin, the sysproperty basedir would be set to ${basedir}, but that is obviously at your discretion.
        Felipe Leme made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Felipe Leme added a comment -

        Just now I realized we should pass these properties to the cactus:test-ear as well....

        Show
        Felipe Leme added a comment - Just now I realized we should pass these properties to the cactus:test-ear as well....
        Felipe Leme made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 1.7 [ 10693 ]
        Hide
        Felipe Leme added a comment -

        Applied patch and add test cases.

        Show
        Felipe Leme added a comment - Applied patch and add test cases.
        Felipe Leme made changes -
        Assignee Felipe Leme [ felipeal ]
        Hide
        Felipe Leme added a comment -

        I will take a look on this issue later...

        Show
        Felipe Leme added a comment - I will take a look on this issue later...
        Maxwell Grender-Jones made changes -
        Field Original Value New Value
        Attachment sysproperties.patch [ 14645 ]
        Maxwell Grender-Jones created issue -

          People

          • Assignee:
            Felipe Leme
            Reporter:
            Maxwell Grender-Jones
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development