[BVAL-111] ValidatorFactory-bound ConstraintValidatorFactory used instead of ValidatorContext-bound instance

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4
• Fix Version/s: 0.5
• Component/s: jsr303
• Assignee: Unassigned
• Reporter: chunlinyao
• Created: 15/Sep/12 02:53
• Updated: 21/Sep/12 22:27
• Resolved: 16/Sep/12 16:12

Description

I have a project use bval-0.2 and CODI-BV modules,after upgrade to bval-0.4 the bval CODI BV modules integration broke.

After some debug I found this line in AnnotationProcessor#getConstraintValidator method.

(ConstraintValidator<A, ? super T>) factoryContext.getFactory().getConstraintValidatorFactory().getInstance(validatorTypes.get(assignableTypes.get(0)));

It use factoryContext.getFactory().getConstraintValidatorFactory()
This line was commit by revision https://svn.apache.org/repos/asf/incubator/bval/sandbox/lang3-work@993590

According to commit log it was extracted from Jsr303MetaBeanFactory.java
But the original version was factoryContext.getConstraintValidatorFactory()

CODI replace factoryContext.constraintValidatorFactory with a CdiAwareConstraintValidatorFactory but the factoryContext.getFactory().getConstraintValidatorFactory() keep the default one.

So, which method is the correct one to get ConstraintValidatorFactory?
Is this a BVal bug or CODI bug?