Uploaded image for project: 'Buildr (Retired)'
  1. Buildr (Retired)
  2. BUILDR-621

ZipTask creates zip file with entries not sorted by path causing very slow unzipping.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.7
    • 1.5
    • Packaging
    • None

    Description

      ZipTask#create_from iterates through the file_map and creates the zip with the entries in no particular order. With a large zip file this can dramatically slow down unzipping since the physical disk has to do much more random access.

      Currently the code does:

      file_map.each do |path, content|

      Doing something such as the following would probably be better:

      paths = file_map.keys.sort
      paths.each do |path|
      content = file_map[path]

      Attachments

        Activity

          People

            toulmean Antoine Toulme
            rteabeault Russell Teabeault
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: