[BUILDR-615] Support non-numeric characters in VersionRequirement (e.g. version = "r09")

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.6
• Fix Version/s: 1.4.8
• Component/s: Dependency management
• Assignee: Alex Boisvert
• Reporter: Alex Boisvert
• Created: 15/Nov/11 11:16
• Updated: 24/Sep/12 00:42
• Resolved: 28/Nov/11 06:27

Description

From this thread: http://buildr.markmail.org/thread/kkpbbzmxyb4ojgbs

Consider the following namespace code:

REQUIRES = ArtifactNamespace.for(self) do |ns|
ns.guava! "com.google.guava:guava:jar:r09"
ns.javassist! "javassist:javassist:jar:3.8.0.GA"
ns.reflections! "org.reflections:reflections:jar:0.9.5-RC1"
end

The guava spec here causes the following error to be raised

Invalid version: "r09"

This is a result of VersionRequirement.version? which checks the version
string against the regex

/^\s*\d[#

{VER_CHARS}

]\s$/

This regex is checked here

raise "Invalid version: #

{version.inspect}

" unless
self.class.version?(version)

So it seems that maybe this regex could be expanded to include versions
like 'r09'.