[BUILDR-611] Buildr should not unnecessarily recompile Java files explicitly added to compile.from

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.6
• Fix Version/s: 1.4.7
• Component/s: Compilers
• Assignee: Peter Donald
• Reporter: Félix Enrique Llorente Pastora
• Created: 14/Sep/11 10:02
• Updated: 15/Nov/12 06:20
• Resolved: 15/Nov/12 06:20

Description

We have something like that in our buildfile

compile.from(FileList[
FooI/jsrc/*/.java',
Bar/jsrc/']
.exclude('FooJava.java'))

Calling build task twice do two compilations.

buildr doesn't remove the ";" character from the package name in the compile_map

We did have to use the following patch to fix it:

— lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
+++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
@@ -193,7 +193,7 @@

1. try to extract package name from .java or .scala files
   if ['.java', '.scala', '.groovy'].include? File.extname(source)
   package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)

• map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
  + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
  elsif
  map[source] = target
  end