[BUILDR-392] Array values not flattened in (one version) of eclipse task properties

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.5
• Fix Version/s: 1.4
• Component/s: IDE
• Labels: eclipse
• Assignee: Unassigned
• Reporter: Peter Dettman
• Created: 02/Mar/10 05:26
• Updated: 22/Jun/11 10:09
• Resolved: 05/Mar/10 05:25

Description

In the section of the docs on Eclipse (http://buildr.apache.org/more_stuff.html#eclipse), this example is given:

eclipse.builders ['org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder']

That actually doesn't work, because it is handled by (eclipse.rb r902466):

def natures(*values)
if values.size > 0
@natures ||= []
@natures += values # <-- This should be values.flatten?
else
@natures || (@project.parent ? @project.parent.eclipse.natures : [])
end
end

it DOES work if assignment is used:

eclipse.builders = ['org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder']

or no explicit array added:

eclipse.builders 'org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder'

I've marked where I think a flatten should be added. By visual inspection, I guess the same problem exists for "classpath_containers", "exclude_libs", and "builders" (also all in eclipse.rb).

Issue Links

• is related to: BUILDR-300 Make the Eclipse task more configurable