[BUILDR-350] CLONE -Failures not reported correclty for ScalaTest (fix included)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.4, 1.3.5
• Fix Version/s: 1.4
• Component/s: Test frameworks
• Environment: all
• Assignee: Daniel Spiewak
• Reporter: Alex Eagle
• Created: 25/Nov/09 06:10
• Updated: 22/Jun/11 10:10
• Resolved: 26/Nov/09 16:06

Description

Today when a ScalaTest fails Buildr doesn't report it correctly and just ends without reporting the correct error or returning an error code.

There is 2 problems:

• The regexp used to now if a test failed is wrong
• The loop reading the reportFile breaks too early, it breaks on the sentence 'Run completed.' but 'TEST FAILED' is on the following line

Here is a fix for it:

Index: lib/buildr/scala/tests.rb
===================================================================
— lib/buildr/scala/tests.rb (revision 811837)
+++ lib/buildr/scala/tests.rb (working copy)
@@ -126,9 +126,9 @@
while (!completed) do
File.open(reportFile, "r") do |input|
while (line = input.gets) do

• failed = (line =~ /(TEST FAILED -)|(RUN STOPPED)|(RUN ABORTED)/) unless failed
  + failed = (line =~ /(TESTS? FAILED)|(RUN STOPPED)|(RUN ABORTED)/) unless failed
  completed |= (line =~ /Run completed\./)
• break if (failed || completed)
  + break if (failed)
  end
  end
  wait += 1

Issue Links

• is a clone of: BUILDR-307 Failures not reported correclty for ScalaTest (fix included)