[BUILDR-325] Overriding package spec with classifer doesn't work

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.4
• Fix Version/s: 1.3.5
• Component/s: Packaging
• Assignee: Unassigned
• Reporter: Antoine Toulme
• Created: 30/Sep/09 23:07
• Updated: 22/Jun/11 10:10
• Resolved: 02/Oct/09 14:11

Description

The current code in package.rb does this:

package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] ||
packages.find

{ |pkg| pkg.name == file_name } ||
packager.call(file_name)

ie, if you define two packages that use the :zip type, only the first one will be taken into account.

I happen to work on Eclipse features, in which both the source and original features work with the same type, but have different classifiers.

So I'd like the code to do this instead:

package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] && (spec[:classifier].nil? || pkg.classifier == spec[:classifier])}) ||
packages.find { |pkg| pkg.name == file_name }

||
packager.call(file_name)