[BROOKLYN-461] Merging config keys: CollectionMerger.Ref.equals always return true

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Assignee: Aled Sage
• Reporter: JC
• Created: 31/Mar/17 20:19
• Updated: 30/Jan/18 10:06
• Resolved: 27/Apr/17 15:14

Description

Hi

In recent github mirror of broolyn-server, I've found the following issue in equals implementation.

Path: utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionMerger.java

196 
197             @Override
198             public boolean equals(Object o) {
199                 if (!(o instanceof Ref)) {
200                     return false;
201                 }
202                 return ((Ref)o).obj == ((Ref)o).obj;
203             }

Line 202 should be like this?

202                 return this.obj == ((Ref)o).obj;

Issue Links

• links to: GitHub Pull Request #626
• links to: GitHub Pull Request #893