[BROOKLYN-128] ArchiveUtils ignores destFile, prefers optionalDestFile during deploy

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7.0-M2
• Fix Version/s: 0.7.0
• Assignee: Unassigned
• Reporter: michael dye
• Created: 26/Jan/15 16:27
• Updated: 02/Dec/15 19:37
• Resolved: 27/Jan/15 13:35

Description

When deploying apps using a Chef recipe, ArchiveUtils.deploy(ResourceUtils, Map<String, ?>, String, SshMachineLocation, String, boolean, String, String) issues an install command with optionalDestFile (which may be null) rather than with destFile which is properly guarded and makes use of optionalDestFile if provided. Stacktrace from NPE encountered:

Failed after 4.62s: Error invoking start at ChefEntityImpl{id=QTkh3uaF}: java.lang.NullPointerException

brooklyn.util.exceptions.PropagatedRuntimeException: Error invoking start at ChefEntityImpl{id=QTkh3uaF}: java.lang.NullPointerException
	at brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:91)
	at brooklyn.util.task.ParallelTask.runJobs(ParallelTask.java:80)
	at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:82)
	at brooklyn.util.task.CompoundTask$1.call(CompoundTask.java:1)
	at brooklyn.util.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:469)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
...
	at brooklyn.util.file.ArchiveUtils.installCommands(ArchiveUtils.java:111)
	at brooklyn.util.file.ArchiveUtils.deploy(ArchiveUtils.java:275)
	at brooklyn.util.file.ArchiveTasks$1$1.run(ArchiveTasks.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at brooklyn.util.task.DynamicSequentialTask$DstJob.call(DynamicSequentialTask.java:337)