[BOOKKEEPER-999] BookKeeper client can leak threads

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4.0
• Fix Version/s: 4.5.0
• Component/s: bookkeeper-client
• Assignee: Robert Joseph Evans
• Reporter: Robert Joseph Evans
• Created: 08/Feb/17 14:44
• Updated: 23/Mar/17 13:18
• Resolved: 22/Mar/17 23:52

Description

The client constructor

BookKeeper(ClientConfiguration conf, ZooKeeper zk)

in 4.4 and above will create a new NioClientSocketChannelFactory but does not set the ownership of that factory to true so threads are leaked.

This showed up as a failure in BookieRecoveryTest on MacOS where it has a hard coded limit of about 2000 threads in a single process, and this test was going beyond that.

Issue Links

• links to: GitHub Pull Request #105