Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-93

bookkeeper doesn't work correctly on OpenLedgerNoRecovery

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0
    • Fix Version/s: 4.0.0
    • Component/s: None
    • Labels:
      None

      Description

      1) bookkeeper hang when openLedgerNoRecovery, since LedgerOpenOp didn't trigger callback when opening ledger no recovery.

      2) race condition in ReadLastConfirmOp

      ReadLastConfirmOp callback on readEntryComplete.
      a) first decrement numResponsePending
      b) then increment validResponses
      c) check validResponses to callback with OK
      b) check numResponsePending to callback with LedgerRecoveryException

      support two callbacks returns on readEntryComplete: A, B. (quorum/ensemble size : 2)

      a) A first decrement numResponsePending from 2 to 1.
      b) A increment validResponses from 0 to 1.
      c) B then decrement numResponsePending from 1 to 0.
      d) A check numResponsePending before B check validResponse, A found the numResponsePending is 0 now. A will callback with exception. But the right action is B check validResponse and callback with OK.

      3) if an LegerHandle is opened by openLedgerNoRecovery, the lastAddConfirmed will be set to -1. so all read requests will be failed since readEntry id > lastAddConfirmed.

      so I suggested that if an LegerHandle is opened by openLegerNoRecovery, the ledgerHandle is under unsafeRead mode. close/write operations will be failed, read operations should not check condition entry_id > lastAddConfirmed.

      1. bookkeeper-93.patch
        12 kB
        Sijie Guo
      2. bookkeeper-93_v2.patch
        8 kB
        Sijie Guo
      3. bookkeeper-93_v3.patch
        8 kB
        Sijie Guo

        Issue Links

          Activity

            People

            • Assignee:
              Ivan Kelly
              Reporter:
              Sijie Guo
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development