Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-925

Fix FindBugs discovered issues in master

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4.0
    • Component/s: None
    • Labels:
      None

      Description

      After we have fixed unit tests in master, we are seeing FindBugs warnings:

      [INFO] --- findbugs-maven-plugin:2.5.2:check (default-cli) @ bookkeeper-server ---
      [INFO] BugInstance size is 6
      [INFO] Error size is 0
      [INFO] Total bugs: 6
      [INFO] Found reliance on default encoding in org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd.runCmd(CommandLine): new String(byte[]) ["org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd"] At BookieShell.java:[lines 403-474]
      [INFO] Exception is caught when Exception is not thrown in org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector.gc(GarbageCollector$GarbageCleaner) ["org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector"] At ScanAndCompareGarbageCollector.java:[lines 64-227]
      [INFO] org.apache.bookkeeper.client.BookieWatcher.<static initializer>() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead ["org.apache.bookkeeper.client.BookieWatcher"] At BookieWatcher.java:[lines 60-308]
      [INFO] org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.LOCK_DATA should be package protected ["org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager"] At ZkLedgerUnderreplicationManager.java:[lines 76-664]
      [INFO] Synchronization performed on java.util.concurrent.ConcurrentLinkedQueue in org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler.writeRequested(ChannelHandlerContext, MessageEvent) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler"] At AuthHandler.java:[lines 210-302]
      [INFO] Synchronization performed on java.util.concurrent.ConcurrentLinkedQueue in org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback.operationComplete(int, Void) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback"] At AuthHandler.java:[lines 333-354]
      [INFO] ------------------------------------------------------------------------
      

        Attachments

          Activity

            People

            • Assignee:
              mmerli Matteo Merli
              Reporter:
              mmerli Matteo Merli
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: