Details

      Description

      Review comment : Using AbstractFuture is too tight with guava's internal implementation. Instead it would be good to use a variable for the settable future.

       class Read... implements GenericCallback {
      
       SettableFuture future = ...;
        public void operationComplete(..) {
          future.set(null); 
          // future.setException(..)
        }
      }
      

        Attachments

        1. 001-BOOKKEEPER-837.patch
          4 kB
          Rakesh Radhakrishnan

          Activity

            People

            • Assignee:
              rakeshr Rakesh Radhakrishnan
              Reporter:
              rakeshr Rakesh Radhakrishnan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: