[BOOKKEEPER-671] PerChannelBookieClient#channelDisconnected can error out other channel's requests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.1
• Component/s: bookkeeper-client
• Assignee: Unassigned
• Reporter: Ivan Kelly
• Created: 13/Aug/13 09:47
• Updated: 09/Oct/17 09:39
• Resolved: 09/Oct/17 09:39

Description

Consider the following.

1. Client calls connect() [state=CONNECTING]
2. Client calls disconnect() before connect finishes [state=DISCONNECTED]
3. Client calls connect() [state=CONNECTING]
4. Connect completes, client writes request [state=CONNECTED]
5. channelDisconnected() from previous disconnect() called

The #channelDisconnected() call will then error out the write request. This is due to the fact that the outstanding request map belongs to the PerChannelBookieClient, rather than to the channel, even though they should belong to the socket on which they were sent out on.

The solution would be to move the completions into the ChannelHandlerContext. At the same time, we can get rid of the separate read and add lists. This information can be in the keys. Perhaps this fix can be done as part of the transaction id changes.

Issue Links

• is related to: BOOKKEEPER-668 Race between PerChannelBookieClient#channelDisconnected() and disconnect() calls can make clients hang while add/reading entries in case of multiple bookie failures