Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-598

Fails to compile - RESUBSCRIBE_EXCEPTION conflict

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.1
    • Fix Version/s: 4.2.2, 4.3.0
    • Component/s: hedwig-client
    • Labels:
      None
    • Environment:

      Fedora 17 w/ gcc version 4.7.2 20120921

      Description

      0. cd hedwig-client/src/main/cpp
      1. autoreconf -fi
      2. ./configure
      3. make

      (3) fails with subscriberimpl.cpp:150:48: error: no match for 'operator==' in '(Hedwig::StatusCode)407u == (const std::type_info)(*(exception.std::exception::_vptr.exception + -8u))'

      The static const RESUBSCRIBE_EXCEPTION is conflicting with an enum from hedwig-client/src/main/cpp/inc/hedwig/protocol.h (line 153 RESUBSCRIBE_EXCEPTION = 407).

      1. BOOKKEEPER-598.patch
        1 kB
        Matthew Farrellee

        Activity

        Hide
        Matthew Farrellee added a comment -

        Patch to avoid complication issue w/ RESUBSCRIBE_EXCEPTION

        Show
        Matthew Farrellee added a comment - Patch to avoid complication issue w/ RESUBSCRIBE_EXCEPTION
        Hide
        Jiannan Wang added a comment -

        I have a try on my new laptop and find the same problem, Matthew's patch works for me. My environment is "gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)" with protobuf 2.4.1.

        However, it seems I have to explicitly add -lboost_thread somewhere to make the link process happy.

        By the way, the newest boost release 1.53 does not compatible with our code since at this release the shared_dynamic_cast is moved out of shared_ptr.hpp. boost-1.52 and before version is ok.

        Show
        Jiannan Wang added a comment - I have a try on my new laptop and find the same problem, Matthew's patch works for me. My environment is "gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)" with protobuf 2.4.1. However, it seems I have to explicitly add -lboost_thread somewhere to make the link process happy. By the way, the newest boost release 1.53 does not compatible with our code since at this release the shared_dynamic_cast is moved out of shared_ptr.hpp. boost-1.52 and before version is ok.
        Hide
        Sijie Guo added a comment -

        yes. I think this issue is introduced when fixing BOOKKEEPER-55. the fix is only made in java client, not in cpp client. after that issue, we don't have any fixes on cpp client, so it is difficult to find this issue. I am thinking we need to build cpp client and run its tests on precommit build, otherwise we could not guarantee the quality of cpp client.

        Show
        Sijie Guo added a comment - yes. I think this issue is introduced when fixing BOOKKEEPER-55 . the fix is only made in java client, not in cpp client. after that issue, we don't have any fixes on cpp client, so it is difficult to find this issue. I am thinking we need to build cpp client and run its tests on precommit build, otherwise we could not guarantee the quality of cpp client.
        Hide
        Sijie Guo added a comment -

        BTW, Ivan Kelly Flavio Junqueira could any one of you add Matthew Farrellee in the contributors list?

        Show
        Sijie Guo added a comment - BTW, Ivan Kelly Flavio Junqueira could any one of you add Matthew Farrellee in the contributors list?
        Hide
        Sijie Guo added a comment -

        ah, forget my previous comment. looks like I could add him

        Show
        Sijie Guo added a comment - ah, forget my previous comment. looks like I could add him
        Hide
        Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-598

        Patch BOOKKEEPER-598.patch downloaded at Fri Apr 5 18:10:58 UTC 2013

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . -1 the patch does not add/modify any testcase
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 833
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/318/

        Show
        Hadoop QA added a comment - Testing JIRA BOOKKEEPER-598 Patch BOOKKEEPER-598.patch downloaded at Fri Apr 5 18:10:58 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 833 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/318/
        Hide
        Sijie Guo added a comment -

        Jiannan Wang

        By the way, the newest boost release 1.53 does not compatible with our code since at this release the shared_dynamic_cast is moved out of shared_ptr.hpp. boost-1.52 and before version is ok.

        Could you create a jira to track this? I am going to commit this one.

        Show
        Sijie Guo added a comment - Jiannan Wang By the way, the newest boost release 1.53 does not compatible with our code since at this release the shared_dynamic_cast is moved out of shared_ptr.hpp. boost-1.52 and before version is ok. Could you create a jira to track this? I am going to commit this one.
        Hide
        Sijie Guo added a comment -

        committed as r1465438. thanks Matthew Farrellee and Jiannan.

        Show
        Sijie Guo added a comment - committed as r1465438. thanks Matthew Farrellee and Jiannan.
        Hide
        Hudson added a comment -

        Integrated in bookkeeper-trunk #168 (See https://builds.apache.org/job/bookkeeper-trunk/168/)
        BOOKKEEPER-598: Fails to compile - RESUBSCRIBE_EXCEPTION conflict (Matthew Farrellee via sijie) (Revision 1465438)

        Result = SUCCESS
        sijie :
        Files :

        • /zookeeper/bookkeeper/trunk/CHANGES.txt
        • /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/subscriberimpl.cpp
        Show
        Hudson added a comment - Integrated in bookkeeper-trunk #168 (See https://builds.apache.org/job/bookkeeper-trunk/168/ ) BOOKKEEPER-598 : Fails to compile - RESUBSCRIBE_EXCEPTION conflict (Matthew Farrellee via sijie) (Revision 1465438) Result = SUCCESS sijie : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/subscriberimpl.cpp
        Hide
        Jiannan Wang added a comment -

        Sijie Guo I've created JIRA BOOKKEEPER-603 for the issue.

        Show
        Jiannan Wang added a comment - Sijie Guo I've created JIRA BOOKKEEPER-603 for the issue.
        Hide
        Sijie Guo added a comment -

        thanks Jiannan Wang

        Show
        Sijie Guo added a comment - thanks Jiannan Wang
        Hide
        Ivan Kelly added a comment -

        Committed revision 1490725 in branch-4.2

        Show
        Ivan Kelly added a comment - Committed revision 1490725 in branch-4.2

          People

          • Assignee:
            Matthew Farrellee
            Reporter:
            Matthew Farrellee
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development