Bookkeeper
  1. Bookkeeper
  2. BOOKKEEPER-540

#stopServingSubscriber when channel is disconnected.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.0
    • Component/s: hedwig-server
    • Labels:
      None

      Description

      as BOOKKEEPER-539 and , some test cases failed due to #stopServingSubscriber issue. Although BOOKKEEPER-529 works out a patch to fix such race condition, it would be better to ensure #stopServingSubscriber when channel is disconnected, to avoid other kind of race and also cleanup the memory.

      (I don't mean to block 4.2.0 release, but there are some test cases found failed related #stopServingSubscriber. so it would be better to handle it before 4.2.0)

      1. BOOKKEEPER-540.patch
        6 kB
        Fangmin Lv
      2. BOOKKEEPER-540.diff
        5 kB
        Sijie Guo

        Activity

        Hide
        Hudson added a comment -

        Integrated in bookkeeper-trunk2 #49 (See https://builds.apache.org/job/bookkeeper-trunk2/49/)
        BOOKKEEPER-540: #stopServingSubscriber when channel is disconnected. (Fangmin via sijie) (Revision 1431235)

        Result = SUCCESS
        sijie :
        Files :

        • /zookeeper/bookkeeper/trunk/CHANGES.txt
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscriptionChannelManager.java
        • /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
        Show
        Hudson added a comment - Integrated in bookkeeper-trunk2 #49 (See https://builds.apache.org/job/bookkeeper-trunk2/49/ ) BOOKKEEPER-540 : #stopServingSubscriber when channel is disconnected. (Fangmin via sijie) (Revision 1431235) Result = SUCCESS sijie : Files : /zookeeper/bookkeeper/trunk/CHANGES.txt /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscriptionChannelManager.java /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
        Hide
        Sijie Guo added a comment -

        committed as r1431235. thanks Fangmin.

        Show
        Sijie Guo added a comment - committed as r1431235. thanks Fangmin.
        Hide
        Fangmin Lv added a comment -

        patch lgtm +1, thanks.

        Show
        Fangmin Lv added a comment - patch lgtm +1, thanks.
        Hide
        Fangmin Lv added a comment -

        Sijie Guo thanks for removing the findbugs warning.

        Show
        Fangmin Lv added a comment - Sijie Guo thanks for removing the findbugs warning.
        Hide
        Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-540

        Patch BOOKKEEPER-540.diff downloaded at Thu Jan 10 06:12:23 UTC 2013

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . -1 the patch does not add/modify any testcase
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 FINDBUGS
        . +1 the patch does not seem to introduce new Findbugs warnings
        +1 TESTS
        . Tests run: 784
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/232/

        Show
        Hadoop QA added a comment - Testing JIRA BOOKKEEPER-540 Patch BOOKKEEPER-540.diff downloaded at Thu Jan 10 06:12:23 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 FINDBUGS . +1 the patch does not seem to introduce new Findbugs warnings +1 TESTS . Tests run: 784 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/232/
        Hide
        Sijie Guo added a comment -

        helping resolving findbugs warning.

        Show
        Sijie Guo added a comment - helping resolving findbugs warning.
        Hide
        Hadoop QA added a comment -

        Testing JIRA BOOKKEEPER-540

        Patch BOOKKEEPER-540.patch downloaded at Wed Jan 9 14:01:24 UTC 2013

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 120
        . -1 the patch does not add/modify any testcase
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 FINDBUGS
        . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [hedwig-server]
        +1 TESTS
        . Tests run: 782
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/226/

        Show
        Hadoop QA added a comment - Testing JIRA BOOKKEEPER-540 Patch BOOKKEEPER-540.patch downloaded at Wed Jan 9 14:01:24 UTC 2013 ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 120 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FINDBUGS . -1 the patch seems to introduce 1 new Findbugs warning(s) in module(s) [hedwig-server] +1 TESTS . Tests run: 782 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/226/
        Hide
        Fangmin Lv added a comment -

        Attach a simple and straightforward patch to remove stub callbacks when channel disconnected.

        Show
        Fangmin Lv added a comment - Attach a simple and straightforward patch to remove stub callbacks when channel disconnected.

          People

          • Assignee:
            Fangmin Lv
            Reporter:
            Sijie Guo
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development