[BOOKKEEPER-163] Prevent incorrect NoSuchLedgerException for readLastConfirmed.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.1.0
• Component/s: bookkeeper-client, bookkeeper-server
• Assignee: Ivan Kelly
• Reporter: Sijie Guo
• Created: 07/Feb/12 11:51
• Updated: 02/May/13 02:29
• Resolved: 13/Mar/12 06:35

Description

bookkeeper client treats NoSuchLedgerException as valid response when reading last confirmed. If NoSuchLedgerException is caused due to an empty directory in following cases, it is an incorrect response.

1) A disk is replaced or ledger index is removed by a sloppy admin.
2) A disk is not mounted when a bookie machine is restarted.

We need a mechanism to prevent such incorrect responses.

Ivan suggested to generate a instance key for each bookie and write it into the ledger directories. If a directory doesn't have the key, and other directories do, then it shouldn't start. This would also resolve the issue that someone starting a new bookie with the same IP as a bookie which has previously died.

Issue Links

• depends upon: BOOKKEEPER-172 Upgrade framework for filesystem layouts
• requires: BOOKKEEPER-170 Bookie constructor starts a number of threads