[BOOKKEEPER-1038] Fix findbugs warnings and upgrade to 3.0.4

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.0
• Fix Version/s: 4.5.0
• Component/s: build
• Assignee: Enrico Olivelli
• Reporter: Enrico Olivelli
• Created: 15/Apr/17 12:13
• Updated: 21/Apr/17 13:38
• Resolved: 20/Apr/17 17:55

Description

This findbugs errors are on master, they have to be fixed

INFO] --- findbugs-maven-plugin:3.0.3:check (default-cli) @ bookkeeper-server ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] Dead store to requested in org.apache.bookkeeper.client.BookieInfoReader.getReadWriteBookieInfo(Collection) [org.apache.bookkeeper.client.BookieInfoReader] At BookieInfoReader.java:[line 166] DLS_DEAD_LOCAL_STORE
[INFO] org.apache.bookkeeper.proto.PerChannelBookieClient$V2CompletionKey overrides equals in PerChannelBookieClient$CompletionKey and may not be symmetric [org.apache.bookkeeper.proto.PerChannelBookieClient$V2CompletionKey] At PerChannelBookieClient.java:[lines 1720-1724] EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC
[INFO] 

Issue Links

• links to: GitHub Pull Request #131