Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0, 0.3.0, 0.2.1
    • Fix Version/s: 0.3.0
    • Component/s: Blur
    • Labels:
      None

      Description

      The QueryStatus object has a field for start time which I assume is for the server date/time that the query was received by Blur, however, this value is always 0. It would be handy in determining load (and running time) if that value was populated.

      1. BLUR-292-MASTER.patch
        3 kB
        Vikrant Navalgund

        Activity

        Show
        Aaron McCurry added a comment - https://git-wip-us.apache.org/repos/asf?p=incubator-blur.git;a=commit;h=7dd4a5c957d425501cb6ad70df9028e50dec14d1 Thanks Vikrant!
        Hide
        Vikrant Navalgund added a comment -

        Hello Aaron,
        By following the description I think I understand the gist of the issue here. Please review the patch and let me know if my understanding is correct.

        I have changed the implementation to do the following:
        1. Set the query start time correctly in the QueryStatus ctor.
        2. Set the query start time correctly in the BlurQuery object whether the query is via the controller or directly on the shard server.

        The returned BlurQuery object will have the correctly populated start time. For example, when we get a 'BlurResults' we can find the query start time by doing a BlurResults.getQuery().getStartTime())

        Test:
        Without the change (Controller/Shard Server)
        <Sample query>
        Total Results: 1
        Query start Time: 0
        BlurResult(locationId:null, score:1.1952736377716064, fetchResult:FetchResult(exists:true, deleted:false, table:employee, rowResult:FetchRowResult(row:Row(id:1, records:null, recordCount:2)), recordResult:null))

        With the Change (Controller/Shard Server)
        <Sample query>
        Total Results: 1
        Query start Time: 1384008931601
        BlurResult(locationId:null, score:1.1952736377716064, fetchResult:FetchResult(exists:true, deleted:false, table:employee, rowResult:FetchRowResult(row:Row(id:1, records:null, recordCount:2)), recordResult:null))

        Regards,
        Vikrant

        Show
        Vikrant Navalgund added a comment - Hello Aaron, By following the description I think I understand the gist of the issue here. Please review the patch and let me know if my understanding is correct. I have changed the implementation to do the following: 1. Set the query start time correctly in the QueryStatus ctor. 2. Set the query start time correctly in the BlurQuery object whether the query is via the controller or directly on the shard server. The returned BlurQuery object will have the correctly populated start time. For example, when we get a 'BlurResults' we can find the query start time by doing a BlurResults.getQuery().getStartTime()) Test: Without the change (Controller/Shard Server) <Sample query> Total Results: 1 Query start Time: 0 BlurResult(locationId:null, score:1.1952736377716064, fetchResult:FetchResult(exists:true, deleted:false, table:employee, rowResult:FetchRowResult(row:Row(id:1, records:null, recordCount:2)), recordResult:null)) With the Change (Controller/Shard Server) <Sample query> Total Results: 1 Query start Time: 1384008931601 BlurResult(locationId:null, score:1.1952736377716064, fetchResult:FetchResult(exists:true, deleted:false, table:employee, rowResult:FetchRowResult(row:Row(id:1, records:null, recordCount:2)), recordResult:null)) Regards, Vikrant

          People

          • Assignee:
            Unassigned
            Reporter:
            Chris Rohr
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development