Uploaded image for project: 'Apache Blur'
  1. Apache Blur
  2. BLUR-261

Unnecessary explicit reference of superclass method by Child class.

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.2.0, 0.3.0, 0.2.1
    • 0.3.0, 0.2.1
    • Blur
    • None

    Attachments

      Activity

        Code Hygiene:
        In the file ThriftBlurControllerServer.java:98, getNodeName() superclass method is explicitly called by using ThriftBlurShardServer.getNodeName() which is wrong. It works right now because this call eventually resolves to the superclass ThriftSever.java getNodeName() method.

        nvikrant Vikrant Navalgund added a comment - Code Hygiene: In the file ThriftBlurControllerServer.java:98, getNodeName() superclass method is explicitly called by using ThriftBlurShardServer.getNodeName() which is wrong. It works right now because this call eventually resolves to the superclass ThriftSever.java getNodeName() method.
        nvikrant Vikrant Navalgund added a comment - - edited

        Hello Aaron/Rahul,
        This is the patch for the issue.

        Regards,
        Vikrant

        nvikrant Vikrant Navalgund added a comment - - edited Hello Aaron/Rahul, This is the patch for the issue. Regards, Vikrant
        amccurry Aaron McCurry added a comment -

        Yep you are right. This patch looks good. But if you could create a patch with the header info (like I commented in BLUR-224) that be great. Thanks!

        Aaron

        amccurry Aaron McCurry added a comment - Yep you are right. This patch looks good. But if you could create a patch with the header info (like I commented in BLUR-224 ) that be great. Thanks! Aaron

        Hello Aaron,
        This is the updated patch file.
        Let me know if its correct.

        Regards,
        Vikrant

        nvikrant Vikrant Navalgund added a comment - Hello Aaron, This is the updated patch file. Let me know if its correct. Regards, Vikrant
        amccurry Aaron McCurry added a comment - https://git-wip-us.apache.org/repos/asf?p=incubator-blur.git;a=commit;h=c0d998704fab49133876541b945ff7e5fd8f1858 https://git-wip-us.apache.org/repos/asf?p=incubator-blur.git;a=commit;h=7ca22cd5e78990ff60479815f5ed3d9fb2c2a887
        amccurry Aaron McCurry added a comment -

        Need to change affects version

        amccurry Aaron McCurry added a comment - Need to change affects version
        amccurry Aaron McCurry added a comment -

        Closing after assignment.

        amccurry Aaron McCurry added a comment - Closing after assignment.
        amccurry Aaron McCurry added a comment -

        Thanks Vikrant!

        Aaron

        amccurry Aaron McCurry added a comment - Thanks Vikrant! Aaron

        People

          Unassigned Unassigned
          nvikrant Vikrant Navalgund
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: