Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-986

install-flume.sh uses -x instead of -e

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6.0, 0.7.0, 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: general
    • Labels:

      Description

      install-flume.sh has at this line (https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/flume/install_flume.sh#L156)
      uses -x.

      We don't need to check for those files being executable so that flag should be changed to -e or something more appropriate.

        Issue Links

          Activity

          Hide
          mgrover Mark Grover added a comment -

          +1 and committed! Thanks, Yi!

          Show
          mgrover Mark Grover added a comment - +1 and committed! Thanks, Yi!
          Hide
          yiyao Yi Yao added a comment -

          BIGTOP-986.patch

          The patch fixes BIGTOP-986: install-flume.sh uses -x instead of -e.

          Show
          yiyao Yi Yao added a comment - BIGTOP-986 .patch The patch fixes BIGTOP-986 : install-flume.sh uses -x instead of -e.
          Hide
          mgrover Mark Grover added a comment - - edited

          Hi Yi,
          I am not table to find you on the JIRA. Konstantin Boudnik, do you know what's going on here? Could you please assign this JIRA to Yi?

          Thanks!

          Show
          mgrover Mark Grover added a comment - - edited Hi Yi, I am not table to find you on the JIRA. Konstantin Boudnik , do you know what's going on here? Could you please assign this JIRA to Yi? Thanks!
          Hide
          yiyao Yi Yao added a comment -

          Hi Mark. Could you assign this big to me? Thanks.

          Show
          yiyao Yi Yao added a comment - Hi Mark. Could you assign this big to me? Thanks.
          Hide
          yiyao Yi Yao added a comment -

          Patch for BIGTOP-986

          Show
          yiyao Yi Yao added a comment - Patch for BIGTOP-986
          Hide
          cos Konstantin Boudnik added a comment -

          If this issue will be addressed by BIGTOP-1244, let's close this one completely.

          Show
          cos Konstantin Boudnik added a comment - If this issue will be addressed by BIGTOP-1244 , let's close this one completely.

            People

            • Assignee:
              yiyao Yi Yao
              Reporter:
              mgrover Mark Grover
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development