Bigtop
  1. Bigtop
  2. BIGTOP-975

HBase regionserver init script does not implement "condrestart" command

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      The init script to support multiple HBase daemons was based on the old Debian template, which didn't implement the "condrestart" command. This is used during upgrades in our RPMs, and it should be implemented.

        Activity

        Hide
        Roman Shaposhnik added a comment -

        +1 and committed!

        Show
        Roman Shaposhnik added a comment - +1 and committed!
        Hide
        Sean Mackrory added a comment -

        I've tested a full upgrade from the last release to these packages and the upgrade no longer fails. condrestart works as I expected and the other commands all still work with offsets provided from all sources.

        Show
        Sean Mackrory added a comment - I've tested a full upgrade from the last release to these packages and the upgrade no longer fails. condrestart works as I expected and the other commands all still work with offsets provided from all sources.
        Hide
        Sean Mackrory added a comment -

        This patch implements the condrestart command (which is somewhat poorly defined in this case, given that you might be running a different set of daemons before and after the conditional restart - basically, if anything is running, it will stop it, and then start using the input you give it). This also highlighted a few areas where a status code might be ambiguous, so I shuffled the status codes to be consistent between multi-daemon and single-daemon modes, and also fixed a few places where the offsets might get mis-formatted while being passed around.

        Show
        Sean Mackrory added a comment - This patch implements the condrestart command (which is somewhat poorly defined in this case, given that you might be running a different set of daemons before and after the conditional restart - basically, if anything is running, it will stop it, and then start using the input you give it). This also highlighted a few areas where a status code might be ambiguous, so I shuffled the status codes to be consistent between multi-daemon and single-daemon modes, and also fixed a few places where the offsets might get mis-formatted while being passed around.

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Sean Mackrory
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development