Bigtop
  1. Bigtop
  2. BIGTOP-973

Improve error diagnostics when sed'ing Hadoop version in Oozie package

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Component/s: RPM
    • Labels:
      None

      Description

      There's no good diagnostics when do-component-build dynamically replaced the target Hadoop version. If the "to be replaced" version isn't present in the Oozie pom files, the error might not surfaced until later or at all: mvn will simply pull in incorrect versions of Hadoop libs. case in point: when doing something like this

      sed -i.orig -e "s#2.0.2-alpha#${HADOOP_VERSION}#" ${WORKDIR}/hadooplibs/hadoop-distcp-2/pom.xml
      

      sed will exit successfully even if no replacement took place. We need to guarantee to fail early.

      1. BIGTOP-973.patch
        1 kB
        Konstantin Boudnik
      2. BIGTOP-973.patch
        1 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          That should do it.

          Show
          Konstantin Boudnik added a comment - That should do it.
          Hide
          Konstantin Boudnik added a comment -

          Also, this fail-early approach will guarantee that we are not missing version update when Oozie is upgraded.

          Show
          Konstantin Boudnik added a comment - Also, this fail-early approach will guarantee that we are not missing version update when Oozie is upgraded.
          Hide
          Peter Linnell added a comment -

          +1

          Show
          Peter Linnell added a comment - +1
          Hide
          Roman Shaposhnik added a comment -

          +1

          Show
          Roman Shaposhnik added a comment - +1
          Hide
          Konstantin Boudnik added a comment -

          A slightly improved version of the patch that actually terminate the build.

          Show
          Konstantin Boudnik added a comment - A slightly improved version of the patch that actually terminate the build.
          Hide
          Konstantin Boudnik added a comment -

          Just committed it as 2dfff51

          Show
          Konstantin Boudnik added a comment - Just committed it as 2dfff51

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development