Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Component/s: tests
    • Labels:
      None

      Description

      I have looked more into BIGTOP-950 and BIGTOP-835.
      It seems that the timeout functionality is completely unused in the current Bigtop. So, being badly implemented in the first place, an attempt to fix it - BIGTOP-950 - actually just restored the original behavior that has existed since 2011.

      Considering all this, I would remove the following SHAs

      bc49df0bf3ed71dbe7a8ded7857b6087d4df8fd0
      b5f900efc17c616dc34704cd520285adcd814e9e

      because fixing non-used code doesn't make any sense.

      1. BIGTOP-953.patch
        8 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          13s 1 Konstantin Boudnik 01/May/13 04:39
          In Progress In Progress Resolved Resolved
          1d 22h 10m 1 Konstantin Boudnik 03/May/13 02:49
          Resolved Resolved Closed Closed
          49d 22h 1 Roman Shaposhnik 22/Jun/13 00:49
          Roman Shaposhnik made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Konstantin Boudnik made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Committed.

          Show
          Konstantin Boudnik added a comment - Committed.
          Hide
          Anatoli Fomenko added a comment -

          Revert patch produces code that looks identical to pre- BIGTOP-835 and BIGTOP-950.
          +1

          Show
          Anatoli Fomenko added a comment - Revert patch produces code that looks identical to pre- BIGTOP-835 and BIGTOP-950 . +1
          Konstantin Boudnik made changes -
          Attachment BIGTOP-953.patch [ 12581414 ]
          Hide
          Konstantin Boudnik added a comment -

          Here's the revert patch.

          Show
          Konstantin Boudnik added a comment - Here's the revert patch.
          Konstantin Boudnik made changes -
          Link This issue relates to BIGTOP-835 [ BIGTOP-835 ]
          Konstantin Boudnik made changes -
          Link This issue relates to BIGTOP-950 [ BIGTOP-950 ]
          Konstantin Boudnik made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Konstantin Boudnik created issue -

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development