Bigtop
  1. Bigtop
  2. BIGTOP-935

Use init script templates for hive

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Hive currently has 3 platform-dependent init script templates. Migrating to use the same template that Sqoop now uses will simplify maintenance now, and ease the transition to SysV init replacements in the future.

        Activity

        Hide
        Roman Shaposhnik added a comment -

        NOTE: I did change CONF_DIR to be "/etc/hive/conf" – I understand the need for flexibility but lets have it as a separate patch.

        Show
        Roman Shaposhnik added a comment - NOTE: I did change CONF_DIR to be "/etc/hive/conf" – I understand the need for flexibility but lets have it as a separate patch.
        Hide
        Roman Shaposhnik added a comment -

        +1 and commited!

        Show
        Roman Shaposhnik added a comment - +1 and commited!
        Hide
        Mark Grover added a comment -

        +1 (non-committer)

        Show
        Mark Grover added a comment - +1 (non-committer)
        Hide
        Mark Grover added a comment -

        Left comment on RB

        Show
        Mark Grover added a comment - Left comment on RB
        Hide
        Sean Mackrory added a comment -

        ReviewBoard entry, if anyone wants to use it: https://reviews.apache.org/r/10779/

        Show
        Sean Mackrory added a comment - ReviewBoard entry, if anyone wants to use it: https://reviews.apache.org/r/10779/
        Hide
        Sean Mackrory added a comment -

        I've tested this patch on Ubuntu, Red Hat and SUSE systems and it all appears to work very well. I feared this would reintroduce lots of subtle issues that had been fixed in the various templates because it cleans up a lot of redundant code, but a 3-way diff showed there was actually very little difference.

        Show
        Sean Mackrory added a comment - I've tested this patch on Ubuntu, Red Hat and SUSE systems and it all appears to work very well. I feared this would reintroduce lots of subtle issues that had been fixed in the various templates because it cleans up a lot of redundant code, but a 3-way diff showed there was actually very little difference.
        Hide
        Sean Mackrory added a comment -

        That very much depends on the timing of 0.6.0, but I'll do my best to get this done within the next couple of days.

        Show
        Sean Mackrory added a comment - That very much depends on the timing of 0.6.0, but I'll do my best to get this done within the next couple of days.
        Hide
        Roman Shaposhnik added a comment -

        That'll be pretty awesome to have for 0.6.0

        Show
        Roman Shaposhnik added a comment - That'll be pretty awesome to have for 0.6.0

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Sean Mackrory
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development