Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Component/s: tests
    • Labels:
      None

      Description

      Let's have some tests for HCatalog

      1. BIGTOP-920.1.patch
        17 kB
        Mark Grover
      2. BIGTOP-920.1.patch-0.3.1
        17 kB
        Mark Grover
      3. BIGTOP-920.2.patch
        17 kB
        Mark Grover
      4. BIGTOP-920.2.patch-0.3.1
        17 kB
        Mark Grover

        Activity

        Hide
        Konstantin Boudnik added a comment -

        Thanks Mark - I will look into the issues you've listed.

        I want to keep this ticket open for 0.3.1 if this is ok with 0.6.0's RM?

        Show
        Konstantin Boudnik added a comment - Thanks Mark - I will look into the issues you've listed. I want to keep this ticket open for 0.3.1 if this is ok with 0.6.0's RM?
        Hide
        Roman Shaposhnik added a comment -

        +1 and committed!

        Show
        Roman Shaposhnik added a comment - +1 and committed!
        Hide
        Mark Grover added a comment -

        And, a new version of the patch with the comment removed for 0.3.1 as well.

        Show
        Mark Grover added a comment - And, a new version of the patch with the comment removed for 0.3.1 as well.
        Hide
        Mark Grover added a comment -

        New version of the patch with an extraneous comment removed from the pom file.

        Show
        Mark Grover added a comment - New version of the patch with an extraneous comment removed from the pom file.
        Hide
        Mark Grover added a comment -

        Cos, sorry about the delay in response. The patch didn't apply cleanly, it had minor conflicts plus the version numbers had to be changed to 0.3.1-incubating instead of 0.6.0.

        I am attaching the patch for branch 0.3.1. As I said before I wasn't able to test this because the artifacts haven't been built for a while. Moreover, the command mvn -f bigtop-tests/test-artifacts/pom.xml clean install
        gave me the following error on 0.3.1 trunk. I tried a clean build of bigtop-test-framework before but that didn't help either.

        ERROR] Failed to execute goal on project bigtop-smokes: Could not resolve dependencies for project org.apache.bigtop.itest:bigtop-smokes:pom:0.3.1-incubating-SNAPSHOT: Failed to collect dependencies for [org.apache.bigtop.itest:itest-common:jar:0.3.1-incubating-SNAPSHOT (compile)]: Failed to read artifact descriptor for org.apache.bigtop.itest:itest-common:jar:0.3.1-incubating-SNAPSHOT: Failure to find org.apache.bigtop:bigtop:pom:0.3.1-incubating-SNAPSHOT in http://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced -> [Help 1]
        

        In any case, the point is that I wasn't able to test much on 0.3.1; however, this patch is very similar to the trunk patch so this would be a very good starting point when 0.3.1 stabilizes.

        Show
        Mark Grover added a comment - Cos, sorry about the delay in response. The patch didn't apply cleanly, it had minor conflicts plus the version numbers had to be changed to 0.3.1-incubating instead of 0.6.0. I am attaching the patch for branch 0.3.1. As I said before I wasn't able to test this because the artifacts haven't been built for a while. Moreover, the command mvn -f bigtop-tests/test-artifacts/pom.xml clean install gave me the following error on 0.3.1 trunk. I tried a clean build of bigtop-test-framework before but that didn't help either. ERROR] Failed to execute goal on project bigtop-smokes: Could not resolve dependencies for project org.apache.bigtop.itest:bigtop-smokes:pom:0.3.1-incubating-SNAPSHOT: Failed to collect dependencies for [org.apache.bigtop.itest:itest-common:jar:0.3.1-incubating-SNAPSHOT (compile)]: Failed to read artifact descriptor for org.apache.bigtop.itest:itest-common:jar:0.3.1-incubating-SNAPSHOT: Failure to find org.apache.bigtop:bigtop:pom:0.3.1-incubating-SNAPSHOT in http: //repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced -> [Help 1] In any case, the point is that I wasn't able to test much on 0.3.1; however, this patch is very similar to the trunk patch so this would be a very good starting point when 0.3.1 stabilizes.
        Hide
        Konstantin Boudnik added a comment -

        It is quite possible because there's an issue with native part of the build. I appreciate you looking into actually running tests - too bad it didn't work. But does the patch applies cleanly? I assume it is yet wanted to make sure...

        Show
        Konstantin Boudnik added a comment - It is quite possible because there's an issue with native part of the build. I appreciate you looking into actually running tests - too bad it didn't work. But does the patch applies cleanly? I assume it is yet wanted to make sure...
        Hide
        Mark Grover added a comment -

        Hey Cos, it looks like Hadoop is broken on Bigtop 0.3.1:
        http://bigtop01.cloudera.org:8080/view/Bigtop-0.3/job/Bigtop-0.3-Hadoop/

        Can you please confirm?

        Show
        Mark Grover added a comment - Hey Cos, it looks like Hadoop is broken on Bigtop 0.3.1: http://bigtop01.cloudera.org:8080/view/Bigtop-0.3/job/Bigtop-0.3-Hadoop/ Can you please confirm?
        Hide
        Mark Grover added a comment -

        Cos, let me try this on 0.3.1. Will let you know.

        Show
        Mark Grover added a comment - Cos, let me try this on 0.3.1. Will let you know.
        Hide
        Mark Grover added a comment -
        Show
        Mark Grover added a comment - Code review at https://reviews.apache.org/r/10935/
        Hide
        Konstantin Boudnik added a comment -

        Mark,

        could you check if this works for 0.3.1 as well? Thanks a million!

        Show
        Konstantin Boudnik added a comment - Mark, could you check if this works for 0.3.1 as well? Thanks a million!
        Hide
        Mark Grover added a comment -

        Adding integration tests for Hcatalog. The tests test some basic Hcat commands, integration of Hcatalog with Hive (via Hive metastore) and integration of HCatalog with Pig.

        Right now all the logical tests are bundled in one test. I was planning to break them up later into individual tests but wanted to post this for review sooner than later.

        Show
        Mark Grover added a comment - Adding integration tests for Hcatalog. The tests test some basic Hcat commands, integration of Hcatalog with Hive (via Hive metastore) and integration of HCatalog with Pig. Right now all the logical tests are bundled in one test. I was planning to break them up later into individual tests but wanted to post this for review sooner than later.

          People

          • Assignee:
            Mark Grover
            Reporter:
            Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development